Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sorting): multi-column sort shouldn't work when option is disabled #348

Merged
merged 1 commit into from
May 21, 2021
Merged

fix(sorting): multi-column sort shouldn't work when option is disabled #348

merged 1 commit into from
May 21, 2021

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented May 21, 2021 •
edited
Loading

  • with Tree Data only supporting single sort, I found out that we could bypass the single sort by using the header menu
  • also found that sort presets with multiple columns were also loading as multiple sort even when the multiColumnSort is disabled and now it's fixed

@ghiscoding
fix(sorting): multi-column sort shouldn't work when option is disabled
bfc8651 
- with Tree Data only supporting single sort, I found out that we could bypass the single sort by using the header menu
- also found that sort presets with multiple columns were also loading as multiple even with the multiColumnSort disabled and now it's fixed
@ghiscoding ghiscoding requested a review from AnnetteZhang May 21, 2021 18:01
@codecov
Copy link

codecov bot commented May 21, 2021

Codecov Report

Merging #348 (bfc8651) into master (9ac7fbf) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #348   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          212       212           
  Lines        13135     13136    +1     
  Branches      4307      4309    +2     
=========================================
+ Hits         13135     13136    +1
Impacted Files Coverage Δ
...kages/common/src/extensions/headerMenuExtension.ts 100.00% <100.00%> (ø)
packages/common/src/services/sort.service.ts 100.00% <100.00%> (ø)
...bundle/src/components/slick-vanilla-grid-bundle.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ac7fbf...bfc8651. Read the comment docs.

@AnnetteZhang AnnetteZhang merged commit 4df95fa into master May 21, 2021
@AnnetteZhang AnnetteZhang deleted the bugfix/single-sort branch May 21, 2021 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnnetteZhang AnnetteZhang AnnetteZhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghiscoding @AnnetteZhang